search

stewdio / beep.js

Beep is a JavaScript toolkit for building browser-based synthesizers.
http://beepjs.com
Other
1.36k stars 85 forks source link

B♯ exists! #2

Open jjt opened 9 years ago

jjt commented 9 years ago

Such as in the key of C♯ major, or an augmented E-G-B triad (which would be E-G-B♯, not E-G-C).

jjt commented 9 years ago

Nice project, BTW!

stewdio commented 9 years ago

Hello, and thanks! Well, I just did some more reading up on it and ... You got me! Do you know of a good concise explantation of that stuff that I myself can get up to speed on and can also link to? Man, I feel like The Simpsons really lied to me. Next you’re going to tell me that epidermis doesn’t mean “hair” :wink:

So it sounds like BEEP.Note is in need of revision then, yes? Suggestions welcome!

chris--young commented 9 years ago

:+1:

jjt commented 9 years ago

The enharmonic equivalents wiki page is a good resource. I haven't had a chance to tuck into the code, but for now you could reword the README to something like

... Note will convert B♯ to its enharmonic equivalent ...

I would submit a PR, but your writing has a definite style that I won't try to ape :)