stewones / angular-morris

Easy use of morris.js with angular.js
https://angular-morris.io
168 stars 62 forks source link

Missing options #55

Closed Adriien-M closed 8 years ago

Adriien-M commented 8 years ago

I wanted to use these undocumented options: barGapand barSizeRatio It will be nice to include them in the options list...

Here is an exemple: http://jsbin.com/nozabinoso/edit?html,js,output

stewones commented 8 years ago

Hey @Adriien-M

I am planning to release a new version soon with some improvements, and this will be one. Thx

pedrohsantana commented 8 years ago

Hi @stewones !

What about select(index)? Are you planning to include it in next release?

And when are yout planning to release it? =)

stewones commented 8 years ago

hey @pedrohsantana yes soon. no dates sry =(

anyway.. you can fork then make your workaround, commit and change your bower.json to use your_user/angular-morris-chart

pedrohsantana commented 8 years ago

Ok, tks Stewan!

Atenciosamente,

Pedro Henrique Santana

Consultoria em Projetos

+55 (34) 3014.2840 | (34) 9 8806.9625

4MM Inovações em Negócios | 4mm.com.br

http://www.droni.com.br/

De: Stewan Pacheco [mailto:notifications@github.com] Enviada em: segunda-feira, 8 de agosto de 2016 16:17 Para: stewones/angular-morris-chart angular-morris-chart@noreply.github.com Cc: pedrohsantana pedrohenrique@4mm.com.br; Mention mention@noreply.github.com Assunto: Re: [stewones/angular-morris-chart] Missing options (#55)

hey @pedrohsantana https://github.com/pedrohsantana
yes soon. no dates sry =(

anyway.. you can fork then make your workaround, commit and change your bower.json to use your_user/angular-morris-chart

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stewones/angular-morris-chart/issues/55#issuecomment-238345976 , or mute the thread https://github.com/notifications/unsubscribe-auth/AT8A4qMV2KnDVWYEF9bkP1r0wxqtil7tks5qd4COgaJpZM4JT5-2 . https://github.com/notifications/beacon/AT8A4okjVzrE-ziOmjhYlZKRsmxKKu10ks5qd4COgaJpZM4JT5-2.gif

sujeetpillai commented 8 years ago

I submitted a pull-request for barGap and barSizeRatio. It's been merged to master. I believe this issue can be close.d

stewones commented 8 years ago

Hi @sujeetpillai make sense thanks for the PR 😄