steyep / alfred-jira

Alfred 3 (or Alfred 2) workflow for interacting with JIRA.
270 stars 60 forks source link

Add dark mode autodetection #116

Open NorthIsUp opened 4 years ago

NorthIsUp commented 4 years ago

Adds detection for system theme and uses the correct icons accordingly.

depends on #117

steyep commented 4 years ago

This updates the workflow icons based on your system theme – not your Alfred theme? How does it behave with custom icons added from the settings app? I'll have to check this out but I'm hesitant to add another dependency to this bloated workflow.

NorthIsUp commented 4 years ago

not your Alfred theme?

Is there a way to infer dark/light from alfred?

I'll have to check this out but I'm hesitant to add another dependency to this bloated workflow.

Fair, but the current icons are unusable and every update I need to re-install the light color ones, so maybe this is worth it? We could also dive into the library and see how it is doing the detection, if it is simple enough we may be able to just take the function we need.