search

steyep / alfred-jira

Alfred 3 (or Alfred 2) workflow for interacting with JIRA.
270 stars 60 forks source link

Make the separator configurable via environment variable #118

Closed NorthIsUp closed 4 years ago

NorthIsUp commented 4 years ago

Alfred supports workflow config via environment variables, this allows users to customize.

I don't think this is the best solution for this but it is the easiest one for right now.

depends on #117

steyep commented 4 years ago

Thanks for the PR! Unfortunately, Alfred-Jira is currently backwards compatible with Alfred2 and this will be a breaking change since workflow variables aren't available in Alfred2. The other issue is that the separator character is relied on pretty heavily for this workflow to function properly, if I recall, and allowing any character to be used could result in undesirable side-effects. For example: if a user configures - to be used as the separator, the workflow will lose context when displaying issues.

This feature request has come up before and I think the ideal way to implement this would be to provide alternative entities to be used as a separator within the settings app. It's not as custom of a solution but it would allow for characters other than ►.

jeffbyrnes commented 4 years ago

@steyep while I admire your desire to maintain compatibility with Alfred 2, perhaps it’s time to at least embrace the features that Alfred 3 provides (released 2016-05-19, or roughly 4 years ago)?

I’m not suggesting that this is necessarily a feature that should land regardless (due to how meaningful the separator is), but I know when I rewrote the handful of workflows I help maintain, the improvements in Alfred 3 (and Alfred 4) made them simpler, yet more resilient.

steyep commented 4 years ago

I don't disagree with you, @jeffbyrnes. There are certainly features in later versions of Alfred that should be utilized for a better experience.

I just meant that this is a feature that could be implemented for users of Alfred 2+ if it's done via the settings app and since that's the case, I found it hard to justify implementing it in such a way that would limit the feature to users of Alfred 3 and later (via Alfred env vars).

But your point that the workflow should be brought into 2020 stands. My little workflow is growing up 😢