search

stfalcon / TinymceBundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project
259 stars 154 forks source link

symfony4 support #222

Closed jzawadzki closed 6 years ago

jzawadzki commented 6 years ago

Hi,

as bundle uses symfony/symfony would not be compatible with upcoming Symfony 4. This pull request tries to change this behaviour to directly require any needed dependencies

Tested on Symfony 3.3 and Symfony 4 Beta4

SymfonyConHackday2017

jzawadzki commented 6 years ago

@LogansUA - looks like a lot of people is using your bundle: https://packagist.org/packages/stfalcon/tinymce-bundle could you review the patch and merge if it's ok so the bundle is prepared for Symfony4 that coming Nov 30? Thanks!

LogansUA commented 6 years ago

@jzawadzki Thank you for this PR, but please contact @stfalcon I'm not maintaining this Bundle anymore.

Good luck :)

fre5h commented 6 years ago

@stfalcon please add https://github.com/AndrewTomMet as master to this repository. I asked him to continue maintain this bundles and he agreed.

emottet commented 6 years ago

Hi. I've just upgrade my project to Symfony 4.0. When I do composer require stfalcon/tinymce-bundle I've got an error that I don't understand: ` Problem 1

Installation failed, reverting ./composer.json to its original content.`

I have symfony 4.0 installed. So any ideas why I get this error?

haroldiedema commented 6 years ago

@emottet Because this PR will resolve the issues you're getting, but it isn't merged yet.

Hopefully @stfalcon can merge this soon.

emottet commented 6 years ago

@haroldiedema Thank you for your answer. Have a nice day!