stfalcon / TinymceBundle

Bundle for connecting TinyMCE (WYSIWYG editor) to your Symfony2 project
259 stars 154 forks source link

Remove period (.) from class selector #230

Closed furison closed 5 years ago

furison commented 6 years ago

When the RegExp.test() function (which is used by the getElementsByClassName function) sees a . at the begining of the string it tries to match an extra character at the begining of the string. If 'tinymce' is the first or only class in the element's class list, RegExp will not match any values and will not display the editor. I have therefore added a substring(1) to the options.selector variable to remove this period

stollr commented 5 years ago

This has already been fixed by #234 some days ago ;-)

I think this PR could be closed? @fre5h

furison commented 5 years ago

Sounds good to me :-)