Add a analysis directory and voltage setter in LPD gui test tab

EmmaHancock commented 5 years ago

Description of Work In the LPD GUI test tab I have added a directory selector that will save the analysis file creating where ever is specified. There is also a voltage setter so you can change the voltage the tiles are tested on. There is a small change to get the LPD fault tile output working again. Link to commits/PR/code https://github.com/stfc-aeg/lpd-detector/commit/02072e3603dfa09bc3f0f9e34f0f8a39c3c67559 Acceptance Criteria I may have gone through long winded routes to get this working, so if anything can be streamlined please let me know. Tests

Code Review

[x] Is the code of an acceptable quality?
[x] Do the changes function as described and is it robust?
[x] Have the changes been documented (e.g. in commits, PR merges, release notes or documentation)?

timcnicholls commented 5 years ago

Hi @EmmaHancock I'll return the favour and review this for you 😄 I'll take a look next week while you're enjoying Venice and discuss when you're back

timcnicholls commented 5 years ago

Reviewed changes with @EmmaHancock and happy that it working as intended. Thanks for your hard work on this Emma!

stfc-aeg / for-review

Add a analysis directory and voltage setter in LPD gui test tab #7