stfc / HartreeParticleDSL

MIT License
1 stars 1 forks source link

C_AOS backend's `println` does not create valid outputs #33

Open LonelyCat124 opened 2 years ago

LonelyCat124 commented 2 years ago

The println function in the C_AOS backend doesn't work correctly due to the requirements for managing pointers etc.

This is a difficult issue to fix right now without more advanced handling of variable names/types, but since the C_AOS backend is a test backend its not essential for now.

Example: println("%f %f", "config->time", "config->dt") or println("%f %f", config.time, config.dt)

both produce printf("%f %f\n", "config.time", "config.dt"); or printf("%f %f\n", config.time, config.dt);

The required output would be printf("%f %f\n", config->time, config->dt

This was broken by the new calling functionality.

LonelyCat124 commented 2 years ago

This is still happening, I expected it to resolve with the variable access changes but not yet.