Open hiker opened 1 year ago
Note that this is not a problem in the PSyIR Fortran reader. This error is raised in parse/algorithm.py that directly reads the fparser tree to create the algorithms layer. @rupertford has been redesigning this bit to create the algorithms layer by raising the representation from the PSyIR. Hopefully this issue goes away with the new codepath.
Are you OK to wait for the new implementation @hiker assuming it fixes the problem? I'm hoping it should on master in around a month, but that relies on no significant issues when trying on all LFRic algorithm files. The issue is #1618.
Yes, I am happy to wait.
PSyclone cannot parse LFRic's
mesh/reference_element_mod.F90
(which was triggered by my dependency analysis for the LFRic driver creation, typically this file is not touched by PSyclone):This is apparently caused by several subroutine/functions using the argument same name for different types - besides
edges
the namethis
is a major issue -reference_element_mod.F90
has three differentthis
:(In order to parse this file, I had to rename many, many variables to avoid these 'name clashes' in parameter names. E.g.:
Once I've renamed these arguments, it parsed fine :( That's a really annoying bug :(