search

stfc / PSyclone

Domain-specific compiler and code transformation system for Finite Difference/Volume/Element Earth-system models in Fortran
BSD 3-Clause "New" or "Revised" License
107 stars 29 forks source link

(closes #1796) Refactor LFRic builtins tests #2640

Closed sergisiso closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (29bba60) to head (f69f3ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2640 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 352 352 Lines 48509 48509 ======================================= Hits 48444 48444 Misses 65 65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergisiso commented 4 months ago

This is ready for review, this PR adds metadata checks to the LFRic builtin tests (which I think were missing) and removes invoke generation checks (which I think are unneeded since its not responsibility of these classes). One for @arporter or @TeranIvy

sergisiso commented 4 months ago

@arporter This is ready for another look, CI-permiting. In addition to your comments, I also noticed there was a separate test file for integer builtins. Since this are empty classes, I thought it was simpler to test them in combination with their parent, and instead of testing the lowering (which they don't alter), I check the metadata, which is the important differing part, and its string (see last commit).

arporter commented 4 months ago

Integration tests were green.