search

stfc / PSyclone

Domain-specific compiler and code transformation system for Finite Difference/Volume/Element Earth-system models in Fortran
BSD 3-Clause "New" or "Revised" License
107 stars 29 forks source link

2641 incorrect module names in psydata #2646

Closed hiker closed 4 months ago

hiker commented 4 months ago

Fixes #2641.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (ae4bc50) to head (2e337f0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2646 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 352 352 Lines 48463 48470 +7 ======================================= + Hits 48398 48405 +7 Misses 65 65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hiker commented 4 months ago

Looks good Joerg. Thanks for tracking this down. You'll need to update the tutorials too - at least tutorial/practicals/nemo/2_nemo_profiling needs tweaking.

Done, indeed I missed the example in the Fortran file (maybe I should just have removed that :) ).

Does the User/Dev Guide have examples that need updating too?

Yes, it did - a bit strange, I was certain I had updated that section, but maybe I am mixing things up. I've updated the user guide, added examples for names used in transformation, and shortened the example for DSL naming (and properly indented them).