stfc / PSyclone

Domain-specific compiler and code transformation system for Finite Difference/Volume/Element Earth-system models in Fortran
BSD 3-Clause "New" or "Revised" License
107 stars 29 forks source link

(Towards #2586) Add support for object-oriented `var =[>] this[%...]%procedure(...)` assignment #2649

Closed JulienRemy closed 4 months ago

JulienRemy commented 4 months ago

Currently pointer assignments of the form var =[>] this[%...]%procedure(...) are CodeBlocks wrapping fparser Function_Reference objects. This converts them to assignments with a call on the rhs.

Notes:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (d92f13f) to head (b974455).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2649 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 352 352 Lines 48507 48509 +2 ======================================= + Hits 48442 48444 +2 Misses 65 65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arporter commented 4 months ago

Hi @JulienRemy, I can't remember what you said about PRs on Monday. Was this the one that's ready for a review?

JulienRemy commented 4 months ago

Hi @arporter, this one is indeed ready to review when you have time for this.

arporter commented 4 months ago

Integration tests were green.