(Closes #2634) fixes and improvements for the 'nemo' tutorials.

stfc / PSyclone

Domain-specific compiler and code transformation system for Finite Difference/Volume/Element Earth-system models in Fortran

BSD 3-Clause "New" or "Revised" License

104 stars 27 forks source link

(Closes #2634) fixes and improvements for the 'nemo' tutorials. #2656

Closed arporter closed 1 month ago

arporter commented 2 months ago

Can nvfortran 24.5 now build the LFRic tutorial examples?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (4297270) to head (aa0a395).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2656 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 353 353 Lines 48818 48821 +3 ======================================= + Hits 48753 48756 +3 Misses 65 65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arporter commented 2 months ago

In looking at the 'compilation' workflow I saw that compilation of the LFRic tutorials with nvfortran was switched off because of previous bugs in that compiler. However, with 24.5 compilation works so I've enabled it :-)

arporter commented 2 months ago

Ready for a first look now. Fixes the issues identified with the tutorials, especially in part 4. Also extends the integration test to compile the LFRic part of the tutorial with the NVIDIA compiler (previously this wasn't possible because of a compiler bug) and to launch the 'solution' to NEMO part 4 on GPU and check the answers.

One for anyone really: @hiker, @LonelyCat124, @sergisiso, @TeranIvy :-)

arporter commented 2 months ago

Ready for another look now @hiker.