Closed sergisiso closed 3 weeks ago
@arporter This is ready for review, it compiles NEMOv5 and LFRic with the new spack repository, where there is software stack to build the applications with gfortran-14 nvhpc-24.5 and intel-24.2.
I addition:
I have not yet deleted the current NEMOv5 version that there is in the nemo_test workflow, because the output is very slightly different: it : 10 |ssh|_max: 0.6483453724882898D+01 |U|_max: 0.5701938594625860D-02 |V|_max: 0.4920016849737715D-01 S_min: 0.2996960233984670D+02 S_max: 0.3102375152368392D+02 it : 10 |ssh|_max: 0.6483453724938688D+01 |U|_max: 0.5701938594606864D-02 |V|_max: 0.4919999106597320D-01 S_min: 0.2996960234052442D+02 S_max: 0.3102375152367826D+02
If the reviewer I ok with this numbers I could update the KGO file, do the nemov5 check for this compiler with exact output match and deleted from the nemov4 workflow.
If the reviewer I ok with this numbers I could update the KGO file, do the nemov5 check for this compiler with exact output match and deleted from the nemov4 workflow.
If this change in the pass-through results is purely because of a change in the compiler version then I'm happy. Probably worth checking that the model is stable for a longer run though (perhaps 500 steps).
@arporter We are now down to 1 NEMOv4 passthrough error (#717) and 0 NEMOv5 passthrough errors! Although I am wondering if we should enable TOP and ICE at least in the passthrough in order to cover more code.
@arporter This is ready for next review
I just realised that I made a typo in the branch name and some commits by referring to 2692, but this PR solves issue 2629, sorry for the confusion
@arporter Ready for another review, I just slightly updated the test filenames and removed del_keys on the workflow.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2698 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 353 353 Lines 48996 49024 +28 ======================================= + Hits 48932 48960 +28 Misses 64 64 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.