search

stfc / PSyclone

Domain-specific compiler and code transformation system for Finite Difference/Volume/Element Earth-system models in Fortran
BSD 3-Clause "New" or "Revised" License
104 stars 27 forks source link

(Closes #2663) add lfric integration tests on gpu #2708

Closed arporter closed 1 week ago

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (1130afd) to head (2f41625). Report is 37 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2708 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 353 353 Lines 49056 49061 +5 ======================================= + Hits 48992 48997 +5 Misses 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arporter commented 3 weeks ago

re. the MongoDB @sergisiso, should I just cut-n-paste what you have for other job steps and edit it appropriately or is there more to it than that?

sergisiso commented 3 weeks ago

@arporter Yes, that's all, it's an unstructured db so it will take whatever fields you want in your insert command.

Once the values are uploaded I do need to modify the chart to include the new series of values.

arporter commented 3 weeks ago

The NEMOv4 integration tests are failing but that doesn't seem to be the fault of this PR (I suspect a race condition as it's the OMP test that fails) and the 'fix NEMO v5' issue #2692 seems to fix it.

arporter commented 3 weeks ago

Ready for a first look. Probably has to be @sergisiso as it involves the integration tests and MongoDB. Note that the transformation script is far from optimal but there are limitations that need to be addressed before we can do better.

arporter commented 2 weeks ago

I've fired off the integration tests again. Should be ready for another look.

arporter commented 2 weeks ago

Taking this back as Lukas has provided me with an updated patch so I'm going to update the GPU test to use the same revision as the CPU tests.

arporter commented 1 week ago

Wow, that was a bit painful but I now have the integration tests working with the same (albeit patched) version of LFRic as the rest of the tests. I've also removed the gist upload. Ready for another look now.

arporter commented 1 week ago

It worked :-) Ready for another look now.