search

stfc / PSyclone

Domain-specific compiler and code transformation system for Finite Difference/Volume/Element Earth-system models in Fortran
BSD 3-Clause "New" or "Revised" License
104 stars 27 forks source link

(Closes #2665) improve error messages for line-length limiting and kernel arguments. #2710

Closed arporter closed 1 week ago

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.86%. Comparing base (e9748d7) to head (6037ad8). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2710 +/- ## ======================================= Coverage 99.86% 99.86% ======================================= Files 353 353 Lines 49024 49030 +6 ======================================= + Hits 48960 48966 +6 Misses 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arporter commented 2 weeks ago

A small change that improves some error messages (related to line-length limiting and kernel-argument checks). One for @hiker, @TeranIvy, @oakleybrunt or @mo-lottieturner.

arporter commented 2 weeks ago

CI and Integration Tests permitting, this is ready for another look now.

arporter commented 2 weeks ago

LFRic integration tests failed but that's because Sergi's token for GH gists has expired so not a problem.

arporter commented 2 weeks ago

Thank you for making the changes :) I can't merge this PR so I suppose I'm giving you permission?

I've given you the power now! You'll need to follow the steps at: https://github.com/stfc/PSyclone/wiki/CodeReview#merging-a-branch-to-master