search

stfc / PSycloneBench

Various benchmarks used to inform PSyclone optimisations
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Nemolite2d omp offload #77

Closed vkatkinson closed 2 years ago

vkatkinson commented 2 years ago

Added functionality for OpenMP GPU offloading.

rupertford commented 2 years ago

@vkatkinson, could you advise on whether you are you are still working on this PR or whether it is ready for review.

vkatkinson commented 2 years ago

Hi @rupertford, it's ready for review.

vkatkinson commented 2 years ago

Hi @rupertford, thanks for the feedback. I've addressed all of your comments.

vkatkinson commented 2 years ago

Thanks @rupertford. I've added in some brief information about the debugging flags and provided further context about the LLVM set up script. Now that I've removed the debugging flags from the C and F90 flags in nvidia.sh, do you think it's worth keeping the debugging options comment below or assume that these can be looked up in the compiler documentation if needed?

rupertford commented 2 years ago

... Now that I've removed the debugging flags from the C and F90 flags in nvidia.sh, do you think it's worth keeping the debugging options comment below or assume that these can be looked up in the compiler documentation if needed?

Yes I think keeping potentially useful options for other users (and ourselves when we come back to it in the future) is definitely a good thing. You would have gotten away with a list and a statement saying to add these for debugging but I have no complaints about the additional detail :-)