Closed rupertford closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
ca11947
) 91.76% compared to head (9370504
) 91.77%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ready for first review from @arporter or @sergisiso
Ready for next review from @arporter
I was all set to merge this but then tried it with PSyclone and get two test failures (both in psyir/symbols/datatype_test.py), e.g.:
> ptree = Fortran2008.Declaration_Construct( string_reader) E AttributeError: module 'fparser.two.Fortran2008' has no attribute 'Declaration_Construct'
Please could you take a look?
This is a bug in PSyclone datatypes.py
. Declaration_Construct
is not a new class in Fortran2008 so should be referenced as Fortran2003.Declaration_Construct
. It worked previously as we include Declaration_Construct
in Fortran2008.py
due to it being subclassed by Declaration_Construct_C1112
, but now we pull in the Fortran2008 classes from __init__.py
which (rightly) does not include any Fortran2003 classes. I've created PSyclone issue 2169.
Ready for next review from @arporter
To split the Fortran2008.py file into a file per class we also need to create an init file within a Fortran2008 directory that allows us to import the Fortran2008 classes as if they were in a single file and generate any required files there as well. This PR does this first part and moves the Fortran2008.py file into the Fortran2008 directory. A subsequent PR will actually split the Fortran2008 file.