stfc / janus-core

Tools for machine learnt interatomic potentials
https://stfc.github.io/janus-core/
BSD 3-Clause "New" or "Revised" License
13 stars 8 forks source link

Split up helpers directory? #144

Open ElliottKasoar opened 4 months ago

ElliottKasoar commented 4 months ago

@federicazanca noted that train.py in helpers doesn't exactly fit with other files in the directory, e.g. utils.py or janus_types.py, which are used more as developer tools.

I originally placed train.py here because it seems closest to mlip_calculators.py, as opposed to single point calculations etc. in the calculations directory, but perhaps a third alternative for user-facing modules such as train.py and (to a lesser extent) mlip_calculators.py would be more appropriate?

alinelena commented 4 months ago

yes good idea