stfc / janus-core

Tools for machine learnt interatomic potentials
https://stfc.github.io/janus-core/
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

Promote CHGNET and M3GNET to full dependencies #192

Closed ElliottKasoar closed 2 months ago

ElliottKasoar commented 2 months ago

Resolves #161

Note: Currently requires pinning dgl, as attempting to install the most recent version gives me an error: ERROR: Could not find a version that satisfies the requirement dgl==2.2.1 (from versions: 0.1.0, 0.1.2, 0.1.3, 1.0.0, 1.0.1, 1.0.4, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 2.1.0) (see issue linked in #161).

ElliottKasoar commented 2 months ago

The README probably could do with updating too to reflect this, including a comment about setting the PyTorch dtype if using multiple MLIPs. (Ideally I'd like to implement a solution where the default dtype is set on use of the calculator in some way, so it's hidden from the user completely, but that's non-trivial.)