stfc / janus-core

Tools for machine learnt interatomic potentials
https://stfc.github.io/janus-core/
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

Test Windows and MacOS #214

Open ElliottKasoar opened 1 month ago

ElliottKasoar commented 1 month ago

I thought we had an issue, but can't find it...

These are experimental, as we can't currently guarantee support/functionality, but this makes it easier to see and fix issues, and hopefully we can get to a point where they are all supported fully.

Currently there seem to be at least a couple that we could address soon:

(I don't suggest fixing them as part of this PR)

Unfortunately I think even "allowed" failures lose the green tick, which is annoying.

ElliottKasoar commented 1 month ago

Errors on latest MacOS should hopefully be fixed in the next CHGNet release (https://github.com/CederGroupHub/chgnet/issues/181).

Assuming we want to test it, we probably want to use self-hosted runners for Intel Mac (and maybe others), since it times out.

ElliottKasoar commented 1 month ago

The Windows issue seems to be due to the availability of built distributions on PyPI. The most recent releases are:

2.2.1, which only seems to include Windows built distributions 2.2.0, which only seems to include MacOS built distributions 2.1.0, which only seems to include linux and MacOS 2.0.0, seems to include built distributions for Windows, MacOS and linux

So a potential solution to ensure compatibility might be reverting to 2.0.0.

Alternatives include: