stfc / janus-core

Tools for machine learnt interatomic potentials
https://stfc.github.io/janus-core/
BSD 3-Clause "New" or "Revised" License
13 stars 8 forks source link

Refactor calculations #224

Closed ElliottKasoar closed 3 months ago

ElliottKasoar commented 3 months ago

Depends on #221 (will need rebasing)

Aims to address part of #206:

Possibly converting geom_opt and eos into classes

Currently, this is a starting point for a more unified interface for the calculations, involving instantiating a class, then running the calculations. At the moment, this includes:

There are a few more changes I want to make across the classes now that they're all more comparable e.g. potentially:

  • Consider the interaction and need for file_prefix and struct_name
    • In some cases e.g. eos, I think they may actually do exactly the same thing
    • I'd propose potentially removing struct_name as an option completely, unless there's a clear benefit, to simplify the setting of file names

but I'll address that in a subsequent PR.