stfc / janus

collection of scripts to train and generate data for machine learnt interatomic potentials
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Dataset units change and extxyz #15

Closed dave452 closed 1 year ago

dave452 commented 1 year ago

Dataset can now read the energies and forces from an extxyz file. Units will be converted when a units specified when writing to a fille.

ElliottKasoar commented 1 year ago

A few things to note (for myself, and to help address the comments):

My feeling is that as long as we set the Frame units correctly, it shouldn't matter too much if ASE assumes the wrong units. We always call change_units_all when units is passed to dataset.write, so this might actually prevent "double counting".

I might need to expand my changes to allow us to set non-n2p2 input units, but in terms of this PR's changes I'm not sure there should be a problem with regard to reading and writing. We might need to consider if there are occasions where we want to manipulate a Dataset before writing, and if the wrong units would be a problem then.

ElliottKasoar commented 1 year ago

Implemented via #29.