search

stfc / pre-commit-hooks

Custom pre-commit hooks for use within our projects
https://stfc.github.io/pre-commit-hooks/
MIT License
2 stars 0 forks source link

Merge dev to main #32

Closed RobFirth closed 5 months ago

RobFirth commented 7 months ago

Description

Merge dev to main

Details

Changes include:

Alex-JG3 commented 6 months ago

versions of python and poetry - agree which we should use

In the CI/CD we have switched 1.8.2 which is much more recent version of poetry. I think the only thing that could cause backwards compatibility issues is (in the pyproject.toml) switching from the old group syntax,

[tool.poetry.dev-dependencies]

to the new group syntax

[tool.poetry.group.dev.dependencies]

According to the documentation, the new syntax was introduced in 1.2. This is an old enough version that I think we can expect users to upgrade to at least 1.2.

For the python version, I think we should stick with 3.9 as the default for the time being. When we upgrade to 3.10 on repo-templates perhaps we can think about testing both 3.9 and 3.10. But, I think that is a job for another PR.

RobFirth commented 6 months ago

I've used git-changelog previously here to have good control over the inclusions in the CHANGELOG.md for repo-templates