search

stfc / rucio

Rucio - Scientific Data Management
http://rucio.cern.ch
Apache License 2.0
0 stars 0 forks source link

lfns should use external scope representations #33

Closed elichad closed 4 years ago

elichad commented 4 years ago

e.g. in RSEProtocol, the lfns2pfns function does not encode the VO in the PFN. An InternalScope with the VO is not always passed in when calling; the function is called both by core with an InternalScope and by rucio-admin with just a scope name.

Similarly, the _get_path and _get_path_nondeterministic_server functions can take either an InternalScope or a string.

This applies to RSEProtocol and any protocols which inherit from it.

Discuss with Martin if the VO needs to be encoded here and if we need to tighten up how the scope is handled on input.

elichad commented 4 years ago

Discussed with Martin. VO encoding is not necessary, but consistent typing for scope input is important. This isn't a multi-VO specific issue, but it does relate to InternalScope so it still comes under our remit.

In single-VO the different types don't seem to cause any issues (the InternalScope is converted to str when creating the path, which uses the external representation), but this could cause strange behaviour for further developments if not fixed.

elichad commented 4 years ago

We've decided to specify that lfns['scope'] use external representations everywhere. This requires some updates to the core.