stfc / rucio

Rucio - Scientific Data Management
http://rucio.cern.ch
Apache License 2.0
0 stars 0 forks source link

Cookies #8

Closed elichad closed 3 years ago

elichad commented 4 years ago

Update cookies to use RSE IDs, not names.

Check if VO needs to be added where accounts are saved into cookies.

patrick-austin commented 4 years ago

Cannot find any instance of cookies relating to RSE IDs or names either in the current codebase or as a closed mainline issue. Maybe this meant cache rather than cookies, as caching against RSE name not ID was an issue (#56)? Cookies do seem to be used when it comes to authenticating tokens at the Web layer, with the majority of references being in WebUI utils. This relates to issues #10 and #25.

elichad commented 4 years ago

It's entirely possible that I mistook the cache for cookies - for a while I thought they overlapped but now I know they don't. If the cookies are just involved in storing auth tokens, I think we can close this.

elichad commented 4 years ago

I misunderstood Patrick's earlier comment - some changes are needed to incorporate the VO where account names are saved into cookies during authentication.

patrick-austin commented 3 years ago

Closed by mainline PR 3886.