search

stffn / declarative_authorization

An unmaintained authorization plugin for Rails. Please fork to support current versions of Rails
MIT License
1.24k stars 233 forks source link

Please declare your dependencies in your gemspec #215

Open zenspider opened 8 years ago

zenspider commented 8 years ago

You're using sexp_processor and ruby_parser but not declaring dependencies on them. Please do so.

daniel-rikowski commented 8 years ago

Did you get them to work? Every time I tried to use the authorization rules browser it failed, because of the parsed s-exps, which cannot be processed by decl_auth. (Last time it worked was around 2009, on Ruby 1.9.3. with 1.8 syntax only)

That is probably because the code is tailored to Ruby 1.8 syntax and possibly to an old version of ruby_parser, too

If that is still the case I'd prefer to remove or extract the non-working features, i.e. the app directory, instead of adding the dependencies, considering the "gimmicky" nature of the rules and usages browsers.

zenspider commented 7 years ago

Welp... this project seems dead. :(

zeiv commented 7 years ago

@zenspider see Authoreyes 😉

Listed as WIP, last commit 3 months ago, but I'm still using it in several production apps without a hitch. Should be mostly a drop-in replacement

zenspider commented 7 years ago

@zeiv I'm not a user. I'm a "victim" :)

This project uses one of my gems irresponsibly and I get bugs filed on it as a result. Hopefully others will see your comment and switch over tho.

zeiv commented 7 years ago

@zenspider Ah, I see. Unfortunate. Yeah, there are a couple pull requests I think to axe the portion that uses sexp_processor and ruby_parser. I don't know if they will ever be merged...