Open yairelmaliah opened 3 years ago
I used the splitting function to determine the individual currencies involved for the purpose of money management. It assumes thats always Forex pairs with 3 Letter Currency codes. For other Symbols that do not follow this naming convention this will probably not work.
It is not actually used afterwards (as das as I remember right now) as my plans for running this as a multi-currency EA have diverted.
I guess you can remove this part of the code.
Although getting false signals might be a different issue. Have you tried running it with the debugger?
On Sun, Feb 21, 2021, 01:10 yairelmaliah notifications@github.com wrote:
Get false signals when using custom symbols. Looking into the code and found the spliting letters functions , can you tell if that is the reason I get false signals or am I doing something wrong ?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stfl/backtestd-expert/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCURSJFT7PSDZN4HYEOHLTABFQHANCNFSM4X6MJGCQ .
Yeah , well I ran a debugger and it led me to this CLASS : CBacktestExpert::PrepareAndOpenShortTrade() . The false signals I've mentioned come from short positions so I guess that makes sense. Still trying to figure out how to fix it . you can see the debugger results in the img attached .
best regards , yair
On Sun, 21 Feb 2021 at 11:05, Stefan Lendl notifications@github.com wrote:
I used the splitting function to determine the individual currencies involved for the purpose of money management. It assumes thats always Forex pairs with 3 Letter Currency codes. For other Symbols that do not follow this naming convention this will probably not work.
It is not actually used afterwards (as das as I remember right now) as my plans for running this as a multi-currency EA have diverted.
I guess you can remove this part of the code.
Although getting false signals might be a different issue. Have you tried running it with the debugger?
On Sun, Feb 21, 2021, 01:10 yairelmaliah notifications@github.com wrote:
Get false signals when using custom symbols. Looking into the code and found the spliting letters functions , can you tell if that is the reason I get false signals or am I doing something wrong ?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stfl/backtestd-expert/issues/15, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAKCURSJFT7PSDZN4HYEOHLTABFQHANCNFSM4X6MJGCQ
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stfl/backtestd-expert/issues/15#issuecomment-782823696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7C6T4AWVA2AU6EVFLRLXDTADEE5ANCNFSM4X6MJGCQ .
Ok. I don't see the img but it looks like you're heading in the right direction to locate the bug. Let me know if you find anything and if I can help you out.
On Sun, Feb 21, 2021, 10:36 yairelmaliah notifications@github.com wrote:
Yeah , well I ran a debugger and it led me to this CLASS : CBacktestExpert::PrepareAndOpenShortTrade() . The false signals I've mentioned come from short positions so I guess that makes sense. Still trying to figure out how to fix it . you can see the debugger results in the img attached .
best regards , yair
On Sun, 21 Feb 2021 at 11:05, Stefan Lendl notifications@github.com wrote:
I used the splitting function to determine the individual currencies involved for the purpose of money management. It assumes thats always Forex pairs with 3 Letter Currency codes. For other Symbols that do not follow this naming convention this will probably not work.
It is not actually used afterwards (as das as I remember right now) as my plans for running this as a multi-currency EA have diverted.
I guess you can remove this part of the code.
Although getting false signals might be a different issue. Have you tried running it with the debugger?
On Sun, Feb 21, 2021, 01:10 yairelmaliah notifications@github.com wrote:
Get false signals when using custom symbols. Looking into the code and found the spliting letters functions , can you tell if that is the reason I get false signals or am I doing something wrong ?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stfl/backtestd-expert/issues/15, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAKCURSJFT7PSDZN4HYEOHLTABFQHANCNFSM4X6MJGCQ
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/stfl/backtestd-expert/issues/15#issuecomment-782823696 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AL7C6T4AWVA2AU6EVFLRLXDTADEE5ANCNFSM4X6MJGCQ
.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stfl/backtestd-expert/issues/15#issuecomment-782827578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKCURVT2ZS6TGYJANR2AZTTADHZPANCNFSM4X6MJGCQ .
Get false signals when using custom symbols. Looking into the code and found the StringSubstr() functions , can you tell if that is the reason I get false signals or am I doing something wrong ? Thanks :)