search

stfnhmplr / homebridge-synology

Control your Synology Diskstation with Homekit
MIT License
161 stars 15 forks source link

Compatibility with latest homebridge release #54

Closed mbierman closed 3 years ago

mbierman commented 3 years ago

Describe The Bug: Plug-in no longer compatible with homebridge.

To Reproduce:

  1. Install latest homebridge.
  2. See error in screenshot below.

Expected behavior: Plug-in is compatible with current homebridge.

Logs:

Show the Homebridge logs here, remove any sensitive information.

Plugin Config:


{
    "accessory": "Synology",
    "name": "",
    "ip": "192.168.0.19",
    "mac": ":43",
    "port": "5001",
    "secure": true,
    "account": "",
    "password": "",
    "version": 6,
    "timeout": 15000,
    "disabled": [
        "temp"
    ]
}

Screenshots: 3033948E-9EFF-4235-A01F-1130E7868E63

Environment:

Tontonpat commented 3 years ago

Hi, that's the same for me.

stfnhmplr commented 3 years ago

See error in screenshot below.

I can't see that you have version 0.4.0 installed. The screenshot below shows just version 0.3.1. Also, I can't see any error message in the screenshot.

"accessory": "Synology",

The Synology must be lowercase --> synology

mbierman commented 3 years ago

Thanks! the capitalization never seemed to matter before. The errors are: 

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
[       ...........] - extract:homebridge-synology: verb lock using /root/.npm/_locks/

But now it is at least installing.

stfnhmplr commented 3 years ago

I still cannot see any error. These are just deprecation warnings during installation that should not have any effect. Did you restart homebridge after installing the latest version of homebridge-synology? After restart entries like this should appear at the log:

[10/14/2021, 7:03:47 AM] [Diskstation] Initializing synology accessory...
[10/14/2021, 7:03:48 AM] [Diskstation] Synology Diskstation finished initializing!
mbierman commented 3 years ago

Yes, it initializes for now. Wouldn't it be best to bring these dependencies up to compatibility before there is a breaking change?

nobiman commented 3 years ago

OK, it initializes, but does not show state or temperature, like v 0.3.1 does. Downgraded to 0.3.1.

stfnhmplr commented 3 years ago

Wouldn't it be best to bring these dependencies up to compatibility before there is a breaking change?

Sure. But these are sub dependencies that belong to https://github.com/homeinstalator/syno. Therefore it's not in the scope of this plugin.