[1.16.4] Crash when handling full Labeled Crates

stfwi / engineers-decor

Engineer's Decor

MIT License

35 stars 16 forks source link

[1.16.4] Crash when handling full Labeled Crates #157

Closed NielsPilgaard closed 3 years ago

NielsPilgaard commented 3 years ago

Original issue: https://github.com/NillerMedDild/Enigmatica6/issues/1010

We're unsure of the exact cause, but the crash report seems to indicate an error in the code.

Crash-report

Version

Forge-1.16.4-35.1.37
engineersdecor-1.16.4-1.1.6

stfwi commented 3 years ago

Hi NillerMed, oh my IDE auto included java.fx.Pair (not the google one) and I didn't see it ;). I push the fix with the mc1.16.5 update today (mod version v1.1.7). Cheers!

stfwi commented 3 years ago

Ok, should be fixed. I made a brief double check on my local server, but currently don't have an Enigmatica6 world there. The exception message was quite clear though what the problem was. Cheers!

stfwi commented 3 years ago

It's up on Curse now. Could you, when you get feedback and it's ok, close the issue? Cheers,-

NielsPilgaard commented 3 years ago

I trust that this does the trick, will re-open otherwise :D Thanks a lot!