search

stfwi / engineers-decor

Engineer's Decor
MIT License
35 stars 16 forks source link

Create Crafts & Addition Induction Heater compatability #165

Closed mrh0 closed 3 years ago

mrh0 commented 3 years ago

CC&A adds an Induction Heater that replaces the IE External Heater, this makes the Induction Heater work as a power boost in the EdFurnace class.

CC&A: https://www.curseforge.com/minecraft/mc-mods/createaddition

stfwi commented 3 years ago

Hey man, thanks for the PR. Let me take a look and reflect on the weekend. Cheers!

stfwi commented 3 years ago

Oky, I double checked and reflected again - and went down a little bit different route by adding a server config for heaters. 

 #Tweaks
 [server.tweaks]
 ...
  #Defines (as comma separated list of full registry names) which items are allowed as external heaters in the Aux slot for powered speed boosting.
  furnace_accepted_heaters = "immersiveengineering:furnace_heater,createaddition:heater"
  ...

Reason is (already to be expressed because you made the effort to dig into the code and make a perfectly valid PR) that IE is the primary for this mod, and I'd like to successively replace the few other hardcoded deps with configs (like the old milk bottle thing etc). I put your PR ref into the changelog accordingly. Cheers!

mrh0 commented 3 years ago

Thanks, this is great!