search

stfwi / engineers-decor

Engineer's Decor
MIT License
35 stars 16 forks source link

Add ability to install inset lights in top-aligned catwalks #215

Closed Quinteger closed 2 years ago

Quinteger commented 2 years ago

Inset lights are very cool and versatile, and pair well with catwalk blocks. Unfortunately, it's not possible to properly attach them to top-aligned catwalks, since you get almost an entire block of empty space between them. You have to use the framed variant, which takes up a lot of vertical space, or resort to bottom-aligned catwalks, which is not always convenient.

This PR adds functionality that is similar in design and implementation to interaction between bottom-aligned catwalks and railings. I tried to keep the original formatting style and cleaned up a few things.

2022-05-22_19 51 42

Additionally, I fixed VoxelShapes for inset and floor lights to make them match their actual shape.

stfwi commented 2 years ago

Hi Sergii, wow that is quite a cool feature you implemented there. I can take a closer look at the weekend and will try to test and build a release as quickly as possible. Cheereo,-

stfwi commented 2 years ago

Hey again, just that you don't think I forgot about this, as it is not pulled in yet - totally short on time currently ;/.

Quinteger commented 2 years ago

All good, also check out the other PR while at it https://github.com/stfwi/engineers-decor/pull/216

stfwi commented 2 years ago

Very nice Sergii, this was actually the first code review someone's ever done on this mod ;) Ty man!