stfwi / engineers-decor

Engineer's Decor
MIT License
35 stars 16 forks source link

Metal Crafting Table can delete held items when closing inventory #224

Closed kinlochuk closed 1 year ago

kinlochuk commented 1 year ago

Overview: As the title says, when holding items with the mouse while in the inventory of the metal crafting table, when closing the inventory the items seemingly vanish, and as far as I can tell are destroyed permanently.

Steps to reproduce:

  1. Open the metal crafting table inventory
  2. Pick up an item stack from the inventory with the mouse
  3. Close the crafting table inventory
  4. Observe the lack of held item stack

Expected outcome: The item stack should either:

Actual outcome:

Effected version(s):

engineers decor-1.18.2-1.1.23

Note: I had other mods installed as well, including JEI and Quark, a full list of these can be provided should the info provided not be enough to reproduce the issue.

stfwi commented 1 year ago

Hi kinlochuk, thanks for the hint. I added a bit of code that moves the carried stack back in the player inventory on close. Could to take a look if it's also resolved in your setup and quickly send feedback? Cheers,-

(version engineersdecor-1.18.2-1.1.25 is in approval on curse)

kinlochuk commented 1 year ago

Hi kinlochuk, thanks for the hint. I added a bit of code that moves the carried stack back in the player inventory on close. Could to take a look if it's also resolved in your setup and quickly send feedback? Cheers,-

(version engineersdecor-1.18.2-1.1.25 is in approval on curse)

Apologies for the delay in getting back to you, I see what I can do :)

kinlochuk commented 1 year ago

I have tested with the same collection of mods I had before, and it appears to have fixed it - on my single player test setup before the switch to 1.18.2-1.1.25, closing the inventory voided my held item, afterwar the update when doing the same thing, it put the item back in my inventory, and when I filled my inventory the item instead dropped on the ground all as expected.

Many thanks - I can roll this out to my private server and let my players know to update their client mods :)

stfwi commented 1 year ago

Very nice, ty for the feedback. Cheers,-