search

stfwi / engineers-decor

Engineer's Decor
MIT License
35 stars 16 forks source link

[Mod Support Request] Dynamic Trees for Cutter #52

Closed Voxel-Friend closed 5 years ago

Voxel-Friend commented 5 years ago

Would it be possible to allow the small tree cutter to work on the dynamic tree's mod, and addons for it? I imagine it wouldn't be too difficult.

stfwi commented 5 years ago

Hi, I'll double check how this can be done.

stfwi commented 5 years ago

Hacked it into the actual beta. Could you also take a look if it does work on your machine? Should chop dytrees of radius 7 or higher.

stfwi commented 5 years ago

The cutter is already out a while, I'll close this then ;)

Lordician commented 5 years ago

The compatibility seems to work fine, but sadly, only for the Dynamic Trees mod only. Can you perhaps make it so that Dynamic Trees from compatibility add-ons (like for BoP, thaumcraft and the ones included in Rustic) are also detected?

(Do i need to open a new issue for this?)

stfwi commented 5 years ago

Hi, no that's ok, I reopen this one.

stfwi commented 5 years ago

Hmm. Ok I have a namespace check for dynamic trees that is likely not needed. Didn't even know that there are compat mod for that. So in the next beta I'll remove that namespace check and we'll see if that applies correctly to the compat mods.

Lordician commented 5 years ago

Will keep my eyes on the next beta and i will try to report back my findings. Thanks in advance!

Lordician commented 5 years ago

Seems to work fine in the beta build (engineersdecor-1.12.2-1.0.15-b2). Thanks!

stfwi commented 5 years ago

Perfect that, thx for double checking so quickly. So I'll close this one then.