search

stfwi / engineers-decor

Engineer's Decor
MIT License
35 stars 16 forks source link

[Compatability/Enchancement] Double Slabs #94

Closed pimalel233 closed 4 years ago

pimalel233 commented 4 years ago

https://github.com/CJMinecraft01/DoubleSlabs/issues/20#issuecomment-609057440 There is a minor incompatability that Double Slabs do not detect your slabs so they can not be improved by the other mod. Appratently it can be easly fixed by adding some extra code in the mod so that the slabs can be detected. Would be nice to see it happen. Thanks for the great mod! MC version: 1.12.2

stfwi commented 4 years ago

Hi, cheers for pinging about that issue, normally I already moved on to 1.14+, but I'll collect and checkout the fix for a maintenance version then. Could take a bit of time though until tackling that.

stfwi commented 4 years ago

Took a quick peek and decided to redirect this with a PR, as my slabs contain additional data/variants and a good solution is probably to put that aspect into the Double Slabs mod.

pimalel233 commented 4 years ago

Thank you kindly :)

stfwi commented 4 years ago

Perfect that, CJ has already merged it. I'll close the issue then.