stfwi / engineers-decor

Engineer's Decor
MIT License
35 stars 16 forks source link

[Bug] Factory Block Placer vs Falling Block Entities #98

Closed DrakoAlcarus closed 4 years ago

DrakoAlcarus commented 4 years ago

When placing Vanilla Concrete Powder into the FBP, it places additional blocks inside the falling entities. This causes the Concrete Powder or any falling block to drop on the ground while the first falling block becomes solid.

You can recreate this with this design I made to auto-process Concrete into the wonderful hard block we know and love: image

Now that I look at it, this design can be very much streamlined to prevent this, however, it does seem to be a valid bug. This can be fixed if you add falling entities to a list of entities that interrupt the machine.

stfwi commented 4 years ago

Hey, good point, I did not have falling blocks on screen. Let me schedule this for 1.1.0-b3 (I built b2 already and was testing). Maybe extending the placement blocking to any entities that can be collided include falling block, if so we'll go with that. Fake lights etc have to be ignored however.

DrakoAlcarus commented 4 years ago

Fake lights and arrows, of course

On Fri, Jun 12, 2020, 9:26 AM stfwi notifications@github.com wrote:

Hey, good point, I did not have falling blocks on screen. Let me schedule this for 1.1.0-b3 (I built b2 already and was testing). Maybe extending the placement blocking to any entities that can be collided include falling block, if so we'll go with that. Fake lights etc have to be ignored however.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stfwi/engineers-decor/issues/98#issuecomment-643369099, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBQRIAEZ4WGGMAB3TR5WLLRWJJLRANCNFSM4N3WTV3A .

stfwi commented 4 years ago

Quickly hacked the collidable-entity check, seems to pass all the quick tests done, also ignoring arrows. Gonna put it in the next release.

DrakoAlcarus commented 4 years ago

Excellent! Very attentive.

On Sun, Jun 14, 2020, 11:54 AM stfwi notifications@github.com wrote:

Quickly hacked the collidable-entity check, seems to pass all the quick tests done, also ignoring arrows. Gonna put it in the next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stfwi/engineers-decor/issues/98#issuecomment-643807052, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBQRIDW6WABWOW6GJOMOATRWUMHHANCNFSM4N3WTV3A .

stfwi commented 4 years ago

Alright, engineersdecor-1.15.2-1.1.0-b3 is uploaded. Could you check and close the issue if the problem is resolved for you? Cheers, -