search

stg-annon / BT-Silver-Base

a base game for BT Silver with some edits
28 stars 18 forks source link

Bug - Snape and Hermione glitch when walking into the office, snapping to different locations. #164

Open CheeseburgerWithFries opened 6 years ago

CheeseburgerWithFries commented 6 years ago

Example GIFs linked below.

Snape and Hermione

Snape seems to only happen prior to the duel, I haven't seen it happen after that. However it happens on every one of his entrances before the duel.

Hermione I've only seen once, on the Day 8 conversation. (I think that's event_15/line 2237 in game\00_hp_rpy\18_events.rpy)

CheeseburgerWithFries commented 6 years ago

I've found the cause, but this will need case-by-case fixing.

The Snape example comes from the screen snape_02 definition in 19_my_screens.rpy. That section defines where to put the Snape chibi after the walking animation has played. The animations are each defined in the individual events, with an example from the first time Snape comes to your office here.

The script tells Snape to walk to the desk at walk_xpos2=360, but the screen has Snape appear at xpos=360+140 after that which causes the 'snap' from 360 to 500 (because of the +140 modifier).

There is no consistency in the script to where Snape walks to before the game calls screen snape_02 with 360, 490 and 500 being seen in a quick glance, so you can't just fix 19_my_screens.rpy and have done with it. If I did that, it'd fix some 'snaps' and cause others to appear. I assume it's like this for other characters as well.

Not a major bug, but could use polishing.

Mad-Merlin commented 6 years ago

all chibis will be fixed with the next update (1.27).