search

stg-tud / MUBench

Other
54 stars 30 forks source link

Missing MUDetect-1 for project chensun cf23b99 #441

Closed lafenzo closed 4 years ago

lafenzo commented 4 years ago

Missing MUDetect-1 for project chensun cf23b99

salsolatragus commented 4 years ago

Could you say a little more? When and where is it missing? What does missing mean here? How did you come to this conclusion? How can I reproduce it? What do you suggest?

lafenzo commented 4 years ago

Missing information(api, description, location...) about misuse MUDetect-1(which was found in paper MSR'19 in project chensun, in line 37 of http://www.st.informatik.tu-darmstadt.de/artifacts/mudetect/Experiment%20R.html), I can't find it in this page(https://github.com/stg-tud/MUBench/tree/master/data/chensun/misuses)

salsolatragus commented 4 years ago

I deleted MUDetect-1 with ddaab45, because we found that is is actually a false positive. The PreparedStatement is correctly closed by the call to DBManager.closeStatement on line 226, even though the API documentation of DBManager says it should be closed using DBManager.closePreparedStatement (both methods are implemented functionally equivalent).

Consequently, the misuse should've been removed from the experiments, which I apparently failed to do. I'm sorry for this confusion.

lafenzo commented 4 years ago

Thanks for your reply!