search

stg-tud / MUDetect

Mozilla Public License 2.0
24 stars 8 forks source link

Fails to map parameter #8

Open salsolatragus opened 6 years ago

salsolatragus commented 6 years ago

We fail to map the parameter in http://mubench.svamann.de/fse18-mudetect-dev/experiments/2/detectors/MuDetect_180227_1_ExtendOnlyDataFlow/projects/itext/versions/5091/misuses/finding-8

nguyenhoan commented 6 years ago

Is this because the parameter type is always PdfArray in all instances of the pattern but PdfStructureElement in this target?

salsolatragus commented 6 years ago

We're using the same label for all data nodes in the matching, so this shouldn't be the problem, as the difference only shows in the display output...

nguyenhoan commented 6 years ago

I remember that in detection, you use literal values when checking data node matches. I thought you also you types when matching non-literal data nodes in similar way.

salsolatragus commented 6 years ago

No, we only ever use the abstracted data-node labels. All data nodes are objects. Everything else introduced too much noise. This didn't change since ICSE. We talked about using concrete names for constants at some point, but I never got around to actually test that and I won't, at this point ;)