sthewissen / MVP

Unofficial app to help MVPs manage their community activities
GNU General Public License v3.0
112 stars 31 forks source link

Created main.yml file to setup GitHub Action #8

Closed saamerm closed 4 years ago

saamerm commented 4 years ago

Created main.yml file to setup GitHub Action

Purpose of Action

Testing

saamerm commented 4 years ago

Woot woot thank you

sthewissen commented 4 years ago

@saamerm I haven't worked with GH Actions yet, so I might be asking a dumb question, but can something be done about the iOS build failing because it has no provisioning profiles yet? Just for a CI it shouldn't need them, but I'm guessing it's related to building in Release mode?

Edit: Also, where is the "Practice" step coming from 🤔

saamerm commented 4 years ago

Hey @sthewissen Yes! I explained it a bit here https://github.com/sthewissen/MVP/pull/13

The GH Action in your repo is a free tool to help make sure that no one breaks the build (Eg: misses a semicolon) in their Pull Request, which is especially helpful with big merge requests, where you want an additional level of check-GH performs a "Rebuild All".

Your iOS csproj file requires additional files in order to build in Release mode, so you were seeing the error. I just removed those build requirements, and so it started working.

The Practice step is not needed at all. It was just introduced to make you more comfortable with using Actions, showing that you can perform multiple mac commands like cd (change directory), ls (list out all the files and directories in that location), and so on. You can see the results of those commands in the output window.

sthewissen commented 4 years ago

Awesome!