search

sthewissen / Xamarin.Forms.PancakeView

An extended ContentView for Xamarin.Forms with rounded corners, borders, shadows and more!
MIT License
865 stars 108 forks source link

Maui -- ? #170

Open marcusts opened 3 years ago

marcusts commented 3 years ago

Hello, and thank you for years of great open source work.

Do you plan to port this to Maui? There's a lot of heat being applied to move to the new platform.

Stephen

sthewissen commented 3 years ago

@marcusts Thankyou! I actually think most of what this does will be built into MAUI. I've seen new border work being done, and things like gradients and the shapes API have already been around in the last versions of Xamarin.Forms so I'm sure they'll be ported as well.

PancakeView could definitely return for MAUI, but it'd probably be as a convenient wrapper around the existing bits. I'd want to wait and see what the built-in bits end up being though.

marcusts commented 3 years ago

Thanks! https://www.marcusts.com Stephen Marcus

949-940-5738 <949-940-5738> @.***

On Fri, Aug 20, 2021 at 12:53 AM Steven Thewissen @.***> wrote:

@marcusts https://github.com/marcusts Thankyou! I actually think most of what this does will be built into MAUI. I've seen new border work being done, and things like gradients and the shapes API have already been around in the last versions of Xamarin.Forms so I'm sure they'll be ported as well.

PancakeView could definitely return for MAUI, but it'd probably be as a convenient wrapper around the existing bits. I'd want to wait and see what the built-in bits end up being though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sthewissen/Xamarin.Forms.PancakeView/issues/170#issuecomment-902506609, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW5SC2W5X7Y7ZGMETHVNSTT5YCWZANCNFSM5CO4FAUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

marcusts commented 3 years ago

Hi Steven,

I have been working with Maui, but they are still missing a decent Frame control/view. So we need yours brought into Maui. I am hoping this will be possible.

Thank you for your hard work!

https://www.marcusts.com Stephen Marcus

949-940-5738 <949-940-5738> @.***

On Fri, Aug 20, 2021 at 12:59 AM Stephen Marcus @.***> wrote:

Thanks! https://www.marcusts.com Stephen Marcus

  • Marcus Technical Services, Inc. * "Where Innovation Meets Excellence"

949-940-5738 <949-940-5738> @.***

On Fri, Aug 20, 2021 at 12:53 AM Steven Thewissen < @.***> wrote:

@marcusts https://github.com/marcusts Thankyou! I actually think most of what this does will be built into MAUI. I've seen new border work being done, and things like gradients and the shapes API have already been around in the last versions of Xamarin.Forms so I'm sure they'll be ported as well.

PancakeView could definitely return for MAUI, but it'd probably be as a convenient wrapper around the existing bits. I'd want to wait and see what the built-in bits end up being though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sthewissen/Xamarin.Forms.PancakeView/issues/170#issuecomment-902506609, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABW5SC2W5X7Y7ZGMETHVNSTT5YCWZANCNFSM5CO4FAUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

varyamereon commented 2 years ago

I second this, I have found the Border control to be pretty sub-standard compared to the pancake view, would be happy to see a Maui version of this too!

maurobernal commented 2 years ago

Hello, with the new Release Candidate of NET MAUI, do you have any date of migrate?

kplkasteel commented 2 years ago

I have also just started to Migrate all my projects to MAUI. I have used pancake view extensively because Frame misses a proper shadow function and the new Shadow everywhere in MAUI is not applied to Frame.

VWilcox2000 commented 2 years ago

Thanks for all your work on Pancake view -- enjoyed it immensely in Xamarin. For those frustrated with the Frame in MAUI -- only 1 radius, now has border issues, and eats gestures not honoring InputTransparent, etc... Stop using <Frame and use <Border instead.

<Border Margin="5,2.5,5,2.5"
        Padding="4"
        BackgroundColor="#d9d9d9"
        Stroke="#d9d9d9"
        Background="{Binding WhiteGradient}">
  <Border.StrokeShape>
    <RoundRectangle CornerRadius="14, 33, 0, 0" />
  </Border.StrokeShape>

It has no stupid shadow you have to set false every time, doesn't have the new need to specify every border, and doesn't eat up touch gestures. That said, @varyamereon above mentioned that he was using Border and still missing some of pancake's features so hopefully Pancake will have plenty to offer. That said, any of you getting here who were ignorant of Border like I was -- change to that from Frame!

npagare commented 2 years ago

Hi @sthewissen, how's it going? As MAUI GA is now in VS 2022 17.3 stable, it will be really helpful if you could bring forward PancakeView to Maui. My app has lots of dependencies on it. Your help will be appreciated.

Looking forward to hearing from you. Thank you.

FreakyAli commented 1 year ago

I doubt this will be moved to Maui, Everything I loved and used PancakeView for in XF, Is Built into Maui...

saamerm commented 1 year ago

Alright Steven has a life and literally no one sponsors it, so he isn't going to be migrating it. Let's support each other and try it! I gave it a try, as you can see in the picture, I got stuck with the DashPatternTypeConverter mainly (and a few other places). Any idea what I can do to migrate that TypeConverter? It seems like ConvertFromInvariantString is not to be used anymore? Any resources you can point me to? cc: @IoTFier @varyamereon @VWilcox2000 @marcusts @maurobernal @kplkasteel

image

marcusts commented 1 year ago

Hi, and thanks for your work!

I don't have much technical knwledge about this topic, sorry. RoundedContentViewRenderer Android.txt RoundedContentViewRenderer IOS.txt

I did find a significant bug thta causes run-time errors. I fixed it in my derivation of the RoundedContentView's native renderers, which had the same error. You should be able to apply it to your new work. I do recommmend throwing run-time errors on projects like this so you can more clearly see why the library behaves the way it does.

I look forward to seeing the end result!

pasha-o commented 1 year ago

Hello @saamerm @sthewissen - just curious to see if the MAUI version will be available.

SarthakB26 commented 9 months ago

Some work is here : https://github.com/felipebaltazar/Maui.PancakeView Not sure how stable it is though

unamed000 commented 9 months ago

Some work is here : https://github.com/felipebaltazar/Maui.PancakeView Not sure how stable it is though

Tried that, the control do not render at all on .NET 8.0 ....

FreakyAli commented 9 months ago

Why aren't you guys using borders...

pasha-o commented 9 months ago

@FreakyAli what's the repo's address?

FreakyAli commented 9 months ago

Add borders using: https://learn.microsoft.com/en-us/dotnet/maui/user-interface/controls/border?view=net-maui-8.0 Add shadows using: https://learn.microsoft.com/en-us/dotnet/maui/user-interface/shadow?view=net-maui-8.0 Add Gradients using : https://learn.microsoft.com/en-us/dotnet/maui/user-interface/brushes/gradient?view=net-maui-8.0

Anything else you will need?

unamed000 commented 9 months ago

Add borders using: https://learn.microsoft.com/en-us/dotnet/maui/user-interface/controls/border?view=net-maui-8.0 Add shadows using: https://learn.microsoft.com/en-us/dotnet/maui/user-interface/shadow?view=net-maui-8.0 Add Gradients using : https://learn.microsoft.com/en-us/dotnet/maui/user-interface/brushes/gradient?view=net-maui-8.0

Anything else you will need?

Simply because we're migrating the old projects that are likely to use Pancake all over 1000 places. For now, I have to make my own PancakeView using what you have addressed above and replace about 300~400 XAML/cs files namespaces.

FreakyAli commented 9 months ago

Add borders using: https://learn.microsoft.com/en-us/dotnet/maui/user-interface/controls/border?view=net-maui-8.0 Add shadows using: https://learn.microsoft.com/en-us/dotnet/maui/user-interface/shadow?view=net-maui-8.0 Add Gradients using : https://learn.microsoft.com/en-us/dotnet/maui/user-interface/brushes/gradient?view=net-maui-8.0 Anything else you will need?

Simply because we're migrating the old projects that are likely to use Pancake all over 1000 places. For now, I have to make my own PancakeView using what you have addressed above and replace about 300~400 XAML/cs files namespaces.

Welcome to software development sir!