search

stianaske / pybotvac

Python module for interacting with Neato Botvac Connected vacuum robots.
MIT License
85 stars 44 forks source link

Avoid missing locale #52

Closed Santobert closed 5 years ago

Santobert commented 5 years ago

Closes: #45

I have already mentioned two different approaches to fixing #45. After some testing this one seems to be more stable. It also looks much cleaner to me.

We want to create a timestamp according to rfc2616.

The official documentation shows an example in ruby:

date = Time.now.utc.strftime("%a, %d %b %Y %H:%M:%S GMT")
# => "Fri, 03 Apr 2015 09:12:31 GMT"

The alternative approach using the babel package can be seen here: https://github.com/Santobert/pybotvac/tree/avoid_missing_locale_1

Santobert commented 5 years ago

@stianaske We can go for the babel alternative as well, but personally I prefer this way because of its robustness and cleanliness.

Santobert commented 5 years ago

:tada:

stianaske commented 5 years ago

Great work! Glad we're rid of the locale.

Santobert commented 5 years ago

Thanks for merging. I'm happy about it as well. Are you planning to release the current version on pypi?

stianaske commented 5 years ago

It should already be on pypi. If not, let me know.

On Fri, Oct 4, 2019, 19:51 Santobert notifications@github.com wrote:

Thanks for merging. I'm happy about it as well. Are you planning to release the current version on pypi?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/stianaske/pybotvac/pull/52?email_source=notifications&email_token=AAILUGV3DY2PYXVZ5THME33QM57CVA5CNFSM4I4EO4EKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMNGKI#issuecomment-538497833, or mute the thread https://github.com/notifications/unsubscribe-auth/AAILUGQCBY3O757QQUT3DDLQM57CVANCNFSM4I4EO4EA .