search

stianaske / pybotvac

Python module for interacting with Neato Botvac Connected vacuum robots.
MIT License
85 stars 44 forks source link

Change default spot-cleaning to Turbo and Double Pass #62

Closed larsvinc closed 4 years ago

larsvinc commented 4 years ago

Added the option to pass parameters for the spot cleaning, and changed the default to "Turbo" and "Double Pass".

This is mainly used with Home Assistant. A different option for HA would be to pass the mode, modifier and spot size as config.

larsvinc commented 4 years ago

Regarding new defaults I agree that this is a point of discussion.

IMHO, Defaulting to "Turbo" should be a relatively non-controversial.

Defaulting to double-pass is somewhat more of a controversy.

I guess both parameters boil down to two cases: 1) If you are at home while using the function, you want Eco / single-pass 2) If you are not at home (which is the case for me), you want Turbo / double-pass

Running spot-cleaning directly from the base is somewhat of a corner case. But for me it makes sense because the robot docking is located in the hallway where all the sand is drawn in from the street. I was the one originally adding spot-cleaning both in pybotvac and in the neato integration in HA for that exact reason. So I am curious as to how much this function is used by others.

Nevertheless, I see two paths forward for the functionality I need: 1) New defaults in pybotvac 2) Config-options in HA (which is way more cumbersome, and it is questionable how useful it is)

Happy to hear other opinions/thoughts here!

stianaske commented 4 years ago

I don't use this feature myself, so I'll trust your judgement regarding the defaults.