search

stianaske / pybotvac

Python module for interacting with Neato Botvac Connected vacuum robots.
MIT License
84 stars 44 forks source link

remove manual cert validation for vorwerk connections #83

Open tofuSCHNITZEL opened 10 months ago

tofuSCHNITZEL commented 10 months ago

Because the certificate for the vorwerk endpoint is not as long lived as the one for neatocloud (1y vs selfsigned until 2045) I suggest removing the manual certificate validation in favour of the requests library built in cert validation. cert_path is used directly as input for requests "verify" option so setting it to "True" should result in requests validating the cert with the systems certificate store.

this PR is the better alternative to https://github.com/stianaske/pybotvac/pull/82 where we would need to monitor the vorkwerk endpoint cert and replace the cert and bump the version for this package every time

tofuSCHNITZEL commented 10 months ago

this still might generate "Unverified HTTPS request is being made" warnings when used in home assistant... not sure why