Closed drmrgd closed 6 years ago
Thank you for the bug report! :)
The import-function should support both the new version of the result file from STAR-Fusion as well as the old one, don't you think? I could add a parameter to the import function that lets the user specify which version they have used (for example importStarfusion(filename, version="0.8.0")
), and let the default value be the most recent version. What do you think?
Thanks for the quick reply! I think that might make a lot of sense to do it that way in order to ensure that most users would have some flexibility. I looked through the data and I can't think of a programmatic way to do this. So, adding a parameter to the function is a great idea.
Note that any API changes (such as adding a new parameter) requires me to do the change in the development version of chimeraviz, which is harder to use for the average user. Then the change will not be available in the release version until the next Bioconductor release. So I I'll do this:
importStarfusion
so that it works for the most recent STAR-Fusion version. This change will happen in both the release version and the devel version.version
to the import functions that let the user specify which version of the fusion-finder they want to import data fram. The default value for the parameter will be the most recent version. This change will only happen in the devel version.Thank you very much, I think this will work fine! I think the timing is probably ok, as it's fairly easy to change the header of the STAR-Fusion output to make the expectations chimeraviz in the event there is an issue. I really appreciate the quick help!
That's taken care of. After the next nightly Bioconductor build importStarfusion
will work with the new format :)
I'll leave this issue open so that I'll remember to implement the version
-parameter in devel.
I've changed my mind about this one. The problem with accepting a "verison" parameter is that the fusion finders will probably many times without actually updating their output format. If chimeraviz were to take a "version" parameter, I would have to add each valid version mapped to each potential output format. I think it would be easier to just stay on top of the outputs of the most recent versions, and if anynoe needs help using a previous version I'll just help writing a custom script for that.
Hi, As of v0.8.0 of STAR-Fusion, it would seem that the column headers of the 'star-fusion.fusion_candidates.final.abridged' have changed, which is causing an error when trying to import the file using
importStarfusion.R
:It looks like in this version of STAR-Fusion, the column headers and data are as follows:
I manually edited the file and verified that import is successful if I change the column headers to match what the function is expecting.