search

stianlagstad / chimeraviz

chimeraviz is an R package that automates the creation of chimeric RNA visualizations.
36 stars 14 forks source link

Assignment to global environment #68

Open Ax3man opened 5 years ago

Ax3man commented 5 years ago

This is just as an FYI. You are currently exporting the rather odd RCircos.Env object to the gobal environment to make your package work: https://github.com/stianlagstad/chimeraviz/blob/master/R/plot_circle.R#L249.

This is not particularly nice, since users now have this floating around their global envir, and it makes R CMD give you a NOTE. Here's a StackOverflow question with a simple alternative solution to the identical issue: https://stackoverflow.com/questions/56875962/r-package-transferring-environment-from-imported-package/56894153#56894153.

Hope this helps!

stianlagstad commented 5 years ago

Hi @Ax3man, thanks for the tip! The solution you posted in that stackoverflow-thread seems like a better way of doing it. I'll leave this issue open, and I'll get back to it when the right motivation finds me.