search

stibiumz / phalcon.eager-loading

Solves N+1 query problem in Phalcon Model
The Unlicense
36 stars 24 forks source link

Some Ideas for the future #2

Closed Surt closed 9 years ago

Surt commented 9 years ago

@stibiumz have you more ideas for the library? I would like to drop some so I created this "issue" post. Feel free to delete it thought, this is your space.

It depends on phalcon framework but would be great to have Relationships returned as ResultSets (and phalcon resultsets need more functionality)

stibiumz commented 9 years ago

Hi, I think that the library fulfills its purpose, but any improvements, suggestions etc. are always welcome, so feel free to comment them

About Phalcon ResultSets, the problem is that objects do not persist in memory, so in each iteration a new object is created and the previous one is destroyed, that's why I've used arrays instead of ResultSets

Surt commented 9 years ago

yes, it's a problem in the Resultset from phalcon. and the way it works with the pdo.

stibiumz commented 9 years ago

So, do you have any suggestions or improvements?

stefanchiriac commented 9 years ago

can you put it in packagist too, please? In case you improve it in the future, to be easier to update. Thanks

stibiumz commented 9 years ago

@stefanchiriac It's already in Packagist, https://packagist.org/packages/stibium/phalcon.eager-loading

stefanchiriac commented 9 years ago

Thank you. I was looking around but couldn't find it