search

stichtingsem / technology-prototype

Source code for any services or APIs created in the technology track in Summer 2020
6 stars 1 forks source link

Sem 16 usage api definitie #50

Closed mcginkel closed 3 years ago

mcginkel commented 3 years ago

Create first usage API.

edwinverwoerd commented 3 years ago

Hi Clifton,

I agree that requesting per week or month is a bit too much. We as MP are indeed obliged to report on the use due to the tender. Often it is about when the 1st time and when the last time. I think information about how often is more within the domain of progress. See also my comment on the issue

Met vriendelijke groet, Edwin Verwoerd Ketenarchitect The cleaner and fixer M: +31 6 290 964 00 www.iddinkgroup.comhttp://www.iddinkgroup.com/

From: Clifton Cunningham notifications@github.com Sent: vrijdag 26 februari 2021 15:50 To: stichtingsem/technology-prototype technology-prototype@noreply.github.com Cc: Edwin Verwoerd edwin.verwoerd@iddinkgroup.com; Review requested review_requested@noreply.github.com Subject: Re: [stichtingsem/technology-prototype] Sem 16 usage api definitie (#50)

@cliftonc commented on this pull request.

In reference/usage.v1.yamlhttps://github.com/stichtingsem/technology-prototype/pull/50#discussion_r583691851:

  • Retrieve the full usage based on a entitlement-id, needs to confirm that the caller is able to access either based on their provider information (they can only see their own usage) in the case of the provider scope.

These I struggle with - I had only envisaged usage at the unique level, not with varying aggregations. What would the usageDate be for 'weekly' or 'monthly' values? I think these aggregates should be different endpoints with a different shape.

I also think usage should be reflective of the entitlement - if an entitlement is at School level, we reflect usage at that level. Otherwise we are in a situation where we are sending more information about commercial usage than was shared with us (e.g. 100 for School X, and instead of receiving 98 for School X, you receive Student 1 ... 98).

Is there a support use case here where you really need to see (as MP) that student X specifically used the product? (as you can also see this in the LA itself).

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/stichtingsem/technology-prototype/pull/50#pullrequestreview-599646081, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP4H3AZ3JYQGKGQ7DMFMWDTTA6YKBANCNFSM4YHJLMMQ.