search

stichtingsem / technology-prototype

Source code for any services or APIs created in the technology track in Summer 2020
6 stars 1 forks source link

Initial implementation of Noordhoff client/server #53

Closed hhaarsma closed 3 years ago

hhaarsma commented 3 years ago

Initial implementation of Noordhoff client/server

dpronk commented 3 years ago

I hope you don’t expect me to do a review of this massive PR / Merge into Master before 13:00 today ….

Kind regards

Danny

Op 8 mrt. 2021, om 09:44 heeft hhaarsma notifications@github.com het volgende geschreven:

@hhaarsma https://github.com/hhaarsma requested your review on: #53 https://github.com/stichtingsem/technology-prototype/pull/53 Initial implementation of Noordhoff client/server as a code owner.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/stichtingsem/technology-prototype/pull/53#event-4419983971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH46FZBXINTMKERMMCGVKTTCSFAXANCNFSM4YY7GSCQ.

cliftonc commented 3 years ago

No, not at all - it's us open sourcing our implementation - so no need for review.

mcginkel commented 3 years ago

Can we move this to another folder? Why is this suddenly the "implementation"? Can we make sub folders with "possible implementations"?

cliftonc commented 3 years ago

Well, it is the implementation of the LA services in the prototype? This isn't 'THE' implementation (if there is such a thing outside of each participant anyway).

Edit - sorry just realised that it isn't in an 'LA' folder - I'll ask @hhaarsma to move.