search

sticilface / Melvanimate

Melvanimate
60 stars 7 forks source link

Load a preset called "Default" at power up if it is there #30

Open probonopd opened 7 years ago

probonopd commented 7 years ago

When I power up my device I want to have it come up with a color... am I the only one?

sticilface commented 7 years ago

Thanks for the input. I'm not sure that I would want to merge this one though! here is my logic!

Melvanimate is a library designed to allow you to add your own effects to an esp8266 to drive ws2812 via an esp8266. in all cases you can specify in the sketch which effects you want to include, which wifi network u want, or use the espmanager.

This pull request would be misleading as there is no effect called Default, so unless you have created a Default effect it won't do anything. The example sketch is just that an example sketch for you to design your own around, and show you the bare minimum, or fully a functional example to get going! There is merit to your suggestion but i think it should live in your own sketch not the example.

I for example have a load of stuff in my 'melvanimate' sketch including.. wemos code to work with alexa, the push button to turn on/reset/factory reset code i shared earlier, file browser etc... so there is lots of stuff not in the example, but you are free to include them.

does that make sense?

probonopd commented 7 years ago

Yes, but would it hurt to have a default in the example which happens to do nothing if you don't explicitly set up a "Default" effect? Btw, i'd love to see an example of how to signal things from an API, e.g., IFTTT.